The term is harsh, and I've heard numerous complaints over "War on X" phrases, as you say, but I think this one is justified/beneficial. It indicates that drugs are the "them", and "us" encompasses legislators, regular people, and users the like.
Except that it is not how it turned out. It turned out that "us" was law enforcement and "them" essentially anyone else.
Mostly any kid smoking small amount of marijuana. Being free of drugs wont necessary help you, because law enforcement so much power, that they can take away your property even if you have done nothing wrong. And you can still get stopped and searched for drugs for no reason.
