Donald Trump has been a public figure for much longer than just the last ten years. By 2008, the Apprentice had already been running for four years. He ran for president in 2000. The portrayal of Biff Tannen in Back to the Future 2 (1989) was partially based on his public persona at the time.
The 1993 movie Super Mario Bros. features both a major and minor antagonist clearly modeled after Donald Trump. He was a well known, highly referenced figure for DECADES before he entered politics. Where are you getting this idea that nobody in 2008 could have been thinking about Donald Trump?
He was literally in the middle of his 13-year run on Network tv. If he hadn't won the presidency, that would be talked about as the apex of his time as a public figure.
And, having been a kid at the time, I remember excitedly talking with friends about how Elon Musk was the real life Tony Stark. We were young enough to be insulated from his controveries, and to not truly appreciate how impossible the Iron Man suit was.
