Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

It would mostly be unnecessary. The separate commits won’t matter after the PR if they’re getting squashed.

Debatably, if you’re making changes during a PR review, it could be helpful to make those changes in relevant commits. That way if someone goes through them during the PR, they get one clean “story”, rather than see the pre-PR commits and the conversation after.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: