Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I like the size of this commit! Makes bisecting all so easy!


The arguments against large commit size do not hold in this case. If you look at it, the patch consists of a few changes to Makefile.am, configure.ac, man/intel.man, src/Makefile.am, and src/intel_module.c, which contain no significant logic, and completely new files in the directories src/sna/ and test/. It's one new feature that is practically self-contained, so I don't see any sense in splitting it up into smaller commits.


Sounds reasonable.


if it's new code, you can't bisect. think about it - you need all the new code to compile. if you only had half, it wouldn't compile.

bisecting only makes sense when it's modifications to existing code that can be applied independently.


Be careful with sarcasm around here.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: