Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Depends how you handle your PRs. If you squash and rebase within Github or similar, no problem.

But ideally interactive rebase before you push your PR and tidy up all those commits into larger topical ones.

Eg.

"DEV-1 - Write tests for widget X calculator" "DEV-1 - Implement widget X calculator" "DEV-1 - Refactor widget X factory service"



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: