My wife and I had split finances while we were dating and for a few years after we got married. The thing that tipped us into "everything shared" was when we were expecting our first kid and my wife left her job. At that point split finances just didn't make any sense. Now we have a system basically identical to the OP's system and everybody is happy with it.