The hardware is solid. I have zero complaints about build quality. You are not obligated to upgrade to the latest OS (but you probably should...). I feel really comfortable saying you can get 4 years out of a mbp. If you really need the out, just in case you need to install windows or linux, wait 2-3 months, just to make sure other people have done it reliably.
There is always risk it's not the "optimal" choice, but it's certainly not the "wrong" choice. MacOS is fine. If you hate it just install something else. (but the brand new stuff might be flakey under windows/linux for a while)
Just read this thread and I'm also comfortable recommending the hardware for three or four years easily. Also, the top level comment describes a small amount of what I went through about 10 years ago that made me switch back to Apple, though I built a hackintosh instead of a laptop.
There is always risk it's not the "optimal" choice, but it's certainly not the "wrong" choice. MacOS is fine. If you hate it just install something else. (but the brand new stuff might be flakey under windows/linux for a while)