> Your comment calls "code review", the practice, "toxic". You go on to suggest that project maintainers "merge [the pull request] already and be done with it"
I'm with you until there :)
> suggesting that the normal review process not apply to this particular diff
If the normal review process is to feel diff should absolutely be commented, then yes, totally, applying it to such a small and casual diff makes what I feel is the ridiculousness of the process totally shine.
Note that I'm not saying the diff should not be read. I'm not saying either we should not comment other people code if we feel there is a problem with it. I'm challenging the fact that this diff should have generated discussion, and call the fact that it had a problem.
I don't think making teams more efficient lead to technical inferiority. And to me, the abuse of commenting code is all about inefficiency (regarding both productivity and sane relations between team members).
I'm with you until there :)
> suggesting that the normal review process not apply to this particular diff
If the normal review process is to feel diff should absolutely be commented, then yes, totally, applying it to such a small and casual diff makes what I feel is the ridiculousness of the process totally shine.
Note that I'm not saying the diff should not be read. I'm not saying either we should not comment other people code if we feel there is a problem with it. I'm challenging the fact that this diff should have generated discussion, and call the fact that it had a problem.
I don't think making teams more efficient lead to technical inferiority. And to me, the abuse of commenting code is all about inefficiency (regarding both productivity and sane relations between team members).